Skip to content

Prevent VSCode from breaking default extension sourcemap references - #709

Merged
CGNonofr merged 1 commit into
mainfrom
lmn/fix-default-extension-sourcemaps
Sep 29, 2025
Merged

Prevent VSCode from breaking default extension sourcemap references#709
CGNonofr merged 1 commit into
mainfrom
lmn/fix-default-extension-sourcemaps

Conversation

@CGNonofr

Copy link
Copy Markdown
Contributor

The VSCode default extension build process replaces the local sourcemap references by links to https://main.vscode-cdn.net/sourcemaps/XXX

It's an issue because:

  • It's currently broken because the url contains undefined instead of the VSCode commit
  • We may have patched the default extensions and the published sourcemap may not be corresponding to the code

I'm not sure why microsoft is doing such transformation 🤷

The change prevent vite from logging a lot of sourcemap errors

@CGNonofr
CGNonofr requested a review from kaisalmen September 29, 2025 13:02

@kaisalmen kaisalmen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will test it with mlc.

@CGNonofr
CGNonofr merged commit c37d829 into main Sep 29, 2025
2 checks passed
@CGNonofr
CGNonofr deleted the lmn/fix-default-extension-sourcemaps branch September 29, 2025 13:35
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 21.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants